Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Thu, 25 Oct 2007 18:27:22 -0700 > [EMAIL PROTECTED] wrote on 10/25/2007 04:05:13 PM: > > > David Stevens <[EMAIL PROTECTED]> wrote: > > > > > What about just removing it, or do you think it's > > > useful for documentation of the order? Either way, >

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Stevens
[EMAIL PROTECTED] wrote on 10/25/2007 04:05:13 PM: > David Stevens <[EMAIL PROTECTED]> wrote: > > > What about just removing it, or do you think it's > > useful for documentation of the order? Either way, > > I don't know whether it's intended to be used for something, perhaps a > debugging macr

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Howells
David Stevens <[EMAIL PROTECTED]> wrote: > What about just removing it, or do you think it's > useful for documentation of the order? Either way, I don't know whether it's intended to be used for something, perhaps a debugging macro. Perhaps it should be #if'd out instead. David - To unsubscrib

Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Stevens
What about just removing it, or do you think it's useful for documentation of the order? Either way, Acked-by: David L Stevens <[EMAIL PROTECTED]> +-DLS - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTE

[PATCH] NET: Mark snmp4_icmp_list[] as being unused

2007-10-25 Thread David Howells
Mark snmp4_icmp_list[] as being unused to avoid the warning it would otherwise incur. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- net/ipv4/proc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/ipv4/proc.c b/net/ipv4/proc.c index fd16cb8..1c0854d 100644 --