Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

Trond Myklebust <[EMAIL PROTECTED]> wrote: > SHUT_RD/SHUT_WR/SHUT_RDWR are the traditional names for these constants > (see 'man 3 shutdown') and so should be easier to remember. Good point. David - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

On Mon, 2007-11-12 at 12:22 +, David Howells wrote: > Trond Myklebust <[EMAIL PROTECTED]> wrote: > > > take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the > > Hmmm... Why SHUT_*? Why not SHUTDOWN_*? SHUT_RD/SHUT_WR/SHUT_RDWR are the traditional names for these constants (see 'man 3 s

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

Trond Myklebust <[EMAIL PROTECTED]> wrote: > take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the Hmmm... Why SHUT_*? Why not SHUTDOWN_*? David - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

On Sun, Nov 11, 2007 at 01:40:14PM -0500, Trond Myklebust wrote: > > On Sun, 2007-11-11 at 10:03 -0800, Mark Fasheh wrote: > > That looks pretty good - any objection to naming the enum and using that > > name in the prototype for kernel_sock_shutdown() so it's even more obvious > > what type of sh

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

On Sun, 2007-11-11 at 10:03 -0800, Mark Fasheh wrote: > On Thu, Nov 08, 2007 at 07:01:36PM -0500, Trond Myklebust wrote: > > From: Trond Myklebust <[EMAIL PROTECTED]> > > > > ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers. > > > > Looking at the sock->op->shutdown() handl

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

On Thu, Nov 08, 2007 at 07:01:36PM -0500, Trond Myklebust wrote: > From: Trond Myklebust <[EMAIL PROTECTED]> > > ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers. > > Looking at the sock->op->shutdown() handlers, it looks as if all of them > take a SHUT_RD/SHUT_WR/SHUT_RDWR

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

Trond Myklebust <[EMAIL PROTECTED]> wrote: > Looking at the sock->op->shutdown() handlers, it looks as if all of them > take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the > RCV_SHUTDOWN/SEND_SHUTDOWN arguments. > Add a helper, and then define the SHUT_* enum to ensure that kernel users > of

[PATCH] NET: Add the helper kernel_sock_shutdown()

From: Trond Myklebust <[EMAIL PROTECTED]> ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers. Looking at the sock->op->shutdown() handlers, it looks as if all of them take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the RCV_SHUTDOWN/SEND_SHUTDOWN arguments. Add a helper, a