Re: [PATCH] Inline net_device_stats

2007-03-28 Thread Rusty Russell
On Wed, 2007-03-28 at 08:52 -0700, Stephen Hemminger wrote: > It would make sense to do it per-cpu and 64 bit for the non-error counters. Well, I looked at the e1000, it doesn't update on every packet anyway, but seems to d/l from the card occasionally. I assume this is the method for high-speed

Re: [PATCH] Inline net_device_stats

2007-03-28 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 28 Mar 2007 08:52:24 -0700 > It would make sense to do it per-cpu and 64 bit for the non-error > counters. Good point, but that's a seperate change. I have no real objection to Rusty's change and if more than one driver uses this thing it's

Re: [PATCH] Inline net_device_stats

2007-03-28 Thread Stephen Hemminger
Rusty Russell wrote: Hi all, Does something like this make sense for future drivers? Cheers, Rusty. === Network drivers which keep stats allocate their own stats structure then write a get_stats() function to return them. It would be nice if this were done by default. 1) Add a new "st

[PATCH] Inline net_device_stats

2007-03-28 Thread Rusty Russell
Hi all, Does something like this make sense for future drivers? Cheers, Rusty. === Network drivers which keep stats allocate their own stats structure then write a get_stats() function to return them. It would be nice if this were done by default. 1) Add a new "stats" field to "struct n