Every other path going from this location in rawv6_bind()
will clear err to zero, so your patch also doesn't fix any
bug.
I knew it didn't fix a bug, I just hadn't noticed the C idiom you
pointed-out until I knew to look for it. rawv6_bind() even does this, duh.
-Brian
-
To unsubscribe fro
From: Brian Haley <[EMAIL PROTECTED]>
Date: Tue, 01 Aug 2006 13:06:03 -0400
> The variable 'err' is set in rawv6_bind() before the address check fails
> instead of after, moved inside if() statement.
>
> Signed-off-by: Brian Haley <[EMAIL PROTECTED]>
This is a common C idiom in the kernel:
The variable 'err' is set in rawv6_bind() before the address check fails
instead of after, moved inside if() statement.
Signed-off-by: Brian Haley <[EMAIL PROTECTED]>
diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 8a30cd8..072b28b 100644
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -240,10 +
