From: Ingo Oeser <[EMAIL PROTECTED]>
Date: Fri, 10 Mar 2006 23:34:26 +0100
> Here are some possible (and trivial) cleanups.
> - use kzalloc() where possible
> - invert allocation failure test like
> if (object) {
> /* Rest of function here */
> }
> to
>
> if (object == NULL)
>
From: Ingo Oeser <[EMAIL PROTECTED]>
Here are some possible (and trivial) cleanups.
- use kzalloc() where possible
- invert allocation failure test like
if (object) {
/* Rest of function here */
}
to
if (object == NULL)
return NULL;
/* Rest of function here */
Signed-o
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
Date: Sun, 12 Feb 2006 02:11:03 +0900 (JST)
> In article <[EMAIL PROTECTED]> (at Sat, 11 Feb 2006 17:37:18 +0100), Ingo
> Oeser <[EMAIL PROTECTED]> says:
>
> > From: Ingo Oeser <[EMAIL PROTECTED]>
> >
> > Here are some possible (and trivial) cleanups.
Hello.
In article <[EMAIL PROTECTED]> (at Sat, 11 Feb 2006 17:37:18 +0100), Ingo Oeser
<[EMAIL PROTECTED]> says:
> From: Ingo Oeser <[EMAIL PROTECTED]>
>
> Here are some possible (and trivial) cleanups.
> - use kzalloc() where possible
> - remove unused label
> - invert allocation failure test
From: Ingo Oeser <[EMAIL PROTECTED]>
Here are some possible (and trivial) cleanups.
- use kzalloc() where possible
- remove unused label
- invert allocation failure test like
if (object) {
/* Rest of function here */
}
to
if (object == NULL)
return NULL;
/* Rest of func
Hello,
thanks for your review!
On Thursday 09 February 2006 17:48, YOSHIFUJI Hideaki wrote:
> Did you test your patch?
No, just visual inspection, sorry.
> Please keep nlmsg_failure, which is used by NLMSG_NEW().
Which is a rather nasty macro :-(
Ok, will do a new version without that change,
Hello.
In article <[EMAIL PROTECTED]> (at Thu, 9 Feb 2006 17:36:16 +0100), Ingo Oeser
<[EMAIL PROTECTED]> says:
> Here are some possible (and trivial) cleanups.
:
> - remove unused label
> @@ -3193,7 +3190,6 @@ static int inet6_fill_ifinfo(struct sk_b
> kfree(array);
> return skb->l
From: Ingo Oeser <[EMAIL PROTECTED]>
Here are some possible (and trivial) cleanups.
- use kzalloc() where possible
- remove unused label
- invert allocation failure test like
if (object) {
/* Rest of function here */
}
to
if (object == NULL)
return NULL;
/* Rest of func
