Re: [PATCH] IPv6/DCCP: Fix memory leak in dccp_v6_do_rcv()

2006-09-28 Thread Andrew Morton
On Fri, 29 Sep 2006 02:45:33 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > > Coverity found what looks like a real leak in > net/dccp/ipv6.c::dccp_v6_do_rcv() > > We may leave via the return inside "if (sk->sk_state == DCCP_OPEN) {" > but at that point we may have allocated opt_skb, but we nev

[PATCH] IPv6/DCCP: Fix memory leak in dccp_v6_do_rcv()

2006-09-28 Thread Jesper Juhl
Coverity found what looks like a real leak in net/dccp/ipv6.c::dccp_v6_do_rcv() We may leave via the return inside "if (sk->sk_state == DCCP_OPEN) {" but at that point we may have allocated opt_skb, but we never free it in that path before the return. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED