Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-19 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sat, 17 Nov 2007 10:41:47 +0100 > [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to > workqueue > > Every 600 seconds (ip_rt_secret_interval), a softirq flush of the whole > ip route cache is triggere

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 18 Nov 2007 10:07:37 +0800 > On Sat, Nov 17, 2007 at 04:45:42PM -0800, David Miller wrote: > > > > Herbert, you asked about just nop'ing out cond_resched() when we're > > doing real preemption. > > > > A lot of code goes: > > > > if (need_resch

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Herbert Xu
On Sat, Nov 17, 2007 at 04:45:42PM -0800, David Miller wrote: > > Herbert, you asked about just nop'ing out cond_resched() when we're > doing real preemption. > > A lot of code goes: > > if (need_resched()) { > /* drop some locks, etc. */ > cond_resched(); >

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 18 Nov 2007 00:29:39 +0800 > However, since you're already working on this as your next step > I can wait :) Me too. Herbert, you asked about just nop'ing out cond_resched() when we're doing real preemption. A lot of code goes: if (need_r

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Herbert Xu
On Sat, Nov 17, 2007 at 05:18:35PM +0100, Eric Dumazet wrote: > > >This seems to be the only potentially softirq caller of rt_run_flush. > >However, I just checked the callers of it and most of them seem to > >hold the RTNL which would indicate that they're in process context. > > > >So do you know

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Eric Dumazet
Herbert Xu a écrit : On Sat, Nov 17, 2007 at 09:41:47AM +, Eric Dumazet wrote: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue Thanks for your work on this Eric! It's very much needed. Thanks :) @@ -667,7 +697,7 @@ void rt_cache_flush(int

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Herbert Xu
On Sat, Nov 17, 2007 at 09:41:47AM +, Eric Dumazet wrote: > > [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to > workqueue Thanks for your work on this Eric! It's very much needed. > @@ -667,7 +697,7 @@ void rt_cache_flush(int delay) > &g

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-17 Thread Eric Dumazet
ing this patch from a thunderbird on a winXP machine, I hope you wont mind... Have a nice week end. [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue Every 600 seconds (ip_rt_secret_interval), a softirq flush of the whole ip route cache is triggered. On loaded

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-16 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 17:40:27 +0100 > + unsigned long fake = 0, *flag_ptr; ... > + /* > + * This is a fast version of : > + * if (process_context && need_resched()) > + */ > + if (unlikely(

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-16 Thread Eric Dumazet
Simon Horman a écrit : Is it ever neccessary to call cond_resched() if rt_hash_table[i].chain is NULL? If not, the following looks cleaner to my eyes: for (i = 0; i <= rt_hash_mask; i++) { rth = rt_hash_table[i].chain; if (!rth) con

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-16 Thread Simon Horman
On Fri, Nov 16, 2007 at 05:40:27PM +0100, Eric Dumazet wrote: > Hello David > > This patch against net-2.6.25 is another step to get a more resistant ip > route cache. > > Thank you > > [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to &g

[PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-16 Thread Eric Dumazet
Hello David This patch against net-2.6.25 is another step to get a more resistant ip route cache. Thank you [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue Every 600 seconds (ip_rt_secret_interval), a softirq flush of the whole ip route cache is triggered