Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-14 Thread David Miller
From: Krzysztof Halasa <[EMAIL PROTECTED]> Date: Fri, 14 Dec 2007 22:28:07 +0100 > Wang Chen <[EMAIL PROTECTED]> writes: > > > [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice > > > > Since the caller and the upper caller doesn

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-14 Thread Krzysztof Halasa
Wang Chen <[EMAIL PROTECTED]> writes: > [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice > > Since the caller and the upper caller doesn't hod the rtnl semaphore. > We should use unregister_netdev instead of unregister_netdevice. NAK, not-a-b

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 11:13:44 +0800 > Let's see who else is doing this: > > [NET]: Check RTNL status in unregister_netdevice > > The caller must hold the RTNL so let's check it in unregister_netdevice. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Goo

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-12 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > From: Wang Chen <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 10:35:56 +0800 > >> [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice > > Applied, thanks for finding and fixing this bug. Let&#x

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-12 Thread David Miller
From: Wang Chen <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 10:35:56 +0800 > [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice > > Since the caller and the upper caller doesn't hod the rtnl semaphore. > We should use unregister_netdev instead

[PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-11 Thread Wang Chen
[PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice Since the caller and the upper caller doesn't hod the rtnl semaphore. We should use unregister_netdev instead of unregister_netdevice. Signed-off-by: Wang Chen <[EMAIL PROTECTED]> --- hdlc_fr.c |6 +++-