Re: [PATCH] Fix various coding-style issues and improve printk() usage

2020-05-23 Thread Stephen Hemminger
On Sat, 23 May 2020 18:06:44 +0200 Armin Wolf wrote: > /* These identify the driver base version and may not be removed. */ > static const char version[] = > - KERN_INFO DRV_NAME ".c:v" DRV_VERSION " " DRV_RELDATE > - " D. Becker/P. Gortmaker\n"; > + "Version " DRV_VERSION " " DRV_R

Re: [PATCH] Fix various coding-style issues and improve printk() usage

2020-05-23 Thread Stephen Hemminger
On Sat, 23 May 2020 18:06:44 +0200 Armin Wolf wrote: > + * > + * Authors and other copyright holders: > + * 1992-2000 by Donald Becker, NE2000 core and various modifications. > + * 1995-1998 by Paul Gortmaker, core modifications and PCI support. > + * Copyright 1993 assigned to the United States

[PATCH] Fix various coding-style issues and improve printk() usage

2020-05-23 Thread Armin Wolf
Fixed a ton of minor checkpatch errors/warnings and replace printk() with pr_info() to pass the corresponding log level. Also modifying the RTL8029 PCI string to include the compatible RTL8029AS nic. The only mayor issue remaining is the missing SPDX tag, but since the exact version of the GPL is n