Re: [PATCH] Fix values type used in test_maps

2017-04-21 Thread David Miller
From: Daniel Borkmann Date: Thu, 20 Apr 2017 23:24:53 +0200 > On 04/20/2017 09:20 PM, David Miller wrote: >> >> Maps of per-cpu type have their value element size adjusted to 8 if it >> is specified smaller during various map operations. >> >> This makes test_maps as a 32-bit binary fail, in fact

Re: [PATCH] Fix values type used in test_maps

2017-04-20 Thread Alexei Starovoitov
On Thu, Apr 20, 2017 at 11:24:53PM +0200, Daniel Borkmann wrote: > On 04/20/2017 09:20 PM, David Miller wrote: > > > >Maps of per-cpu type have their value element size adjusted to 8 if it > >is specified smaller during various map operations. > > > >This makes test_maps as a 32-bit binary fail, in

Re: [PATCH] Fix values type used in test_maps

2017-04-20 Thread Daniel Borkmann
On 04/20/2017 09:20 PM, David Miller wrote: Maps of per-cpu type have their value element size adjusted to 8 if it is specified smaller during various map operations. This makes test_maps as a 32-bit binary fail, in fact the kernel writes past the end of the value's array on the user's stack.

[PATCH] Fix values type used in test_maps

2017-04-20 Thread David Miller
Maps of per-cpu type have their value element size adjusted to 8 if it is specified smaller during various map operations. This makes test_maps as a 32-bit binary fail, in fact the kernel writes past the end of the value's array on the user's stack. To be quite honest, I think the kernel should