Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-09-01 Thread David S. Miller
From: Geoff Levand <[EMAIL PROTECTED]> Date: Mon, 29 Aug 2005 15:04:24 -0700 > Sure, your fix works, and seems to be the best way to do it. > > Signed-off-by: Geoff Levand <[EMAIL PROTECTED]> Applied, thanks everyone. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-29 Thread Geoff Levand
David S. Miller wrote: > You're taking my suggestion way too far. > > Just replicate gem_interrupt() inline into gem_poll_controller(), > removing the irrelevant bits by hand. You shouldn't need to > modify gem_poll() at all, just as in your original patch. > I found that execution would go gem

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-29 Thread Geoff Levand
Eric Lemoine wrote: > On 8/27/05, Eric Lemoine <[EMAIL PROTECTED]> wrote: > >>On 8/27/05, Eric Lemoine <[EMAIL PROTECTED]> wrote: >> >>>On 8/26/05, Geoff Levand <[EMAIL PROTECTED]> wrote: >>> This fixes a major bug in the Sun GEM Ether driver's netpoll implementation. When both polled >>>

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-28 Thread Eric Lemoine
On 8/27/05, Eric Lemoine <[EMAIL PROTECTED]> wrote: > On 8/27/05, Eric Lemoine <[EMAIL PROTECTED]> wrote: > > On 8/26/05, Geoff Levand <[EMAIL PROTECTED]> wrote: > > > This fixes a major bug in the Sun GEM Ether > > > driver's netpoll implementation. When both polled > > > and interrupt driven i/o

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-27 Thread Eric Lemoine
On 8/27/05, Eric Lemoine <[EMAIL PROTECTED]> wrote: > On 8/26/05, Geoff Levand <[EMAIL PROTECTED]> wrote: > > This fixes a major bug in the Sun GEM Ether > > driver's netpoll implementation. When both polled > > and interrupt driven i/o are used simultaneously, > > for example when using kgdb over

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-27 Thread Eric Lemoine
On 8/26/05, Geoff Levand <[EMAIL PROTECTED]> wrote: > This fixes a major bug in the Sun GEM Ether > driver's netpoll implementation. When both polled > and interrupt driven i/o are used simultaneously, > for example when using kgdb over Ether with active > NFS mounts, a condition easily arises whe

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-26 Thread David S. Miller
You're taking my suggestion way too far. Just replicate gem_interrupt() inline into gem_poll_controller(), removing the irrelevant bits by hand. You shouldn't need to modify gem_poll() at all, just as in your original patch. - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-26 Thread Geoff Levand
David S. Miller wrote: > From: Geoff Levand <[EMAIL PROTECTED]> > Date: Thu, 25 Aug 2005 22:13:57 -0700 > > >>@@ -970,7 +970,8 @@ >> /* gem_interrupt is safe to reentrance so no need >> * to disable_irq here. >> */ >>- gem_interrupt(dev->irq, dev, NULL); >>+ if(gem_interr

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-25 Thread David S. Miller
From: Geoff Levand <[EMAIL PROTECTED]> Date: Thu, 25 Aug 2005 22:13:57 -0700 > @@ -970,7 +970,8 @@ > /* gem_interrupt is safe to reentrance so no need >* to disable_irq here. >*/ > - gem_interrupt(dev->irq, dev, NULL); > + if(gem_interrupt(dev->irq, dev, NULL) == IRQ_

[PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-25 Thread Geoff Levand
This fixes a major bug in the Sun GEM Ether driver's netpoll implementation. When both polled and interrupt driven i/o are used simultaneously, for example when using kgdb over Ether with active NFS mounts, a condition easily arises where the bug is hit. The problem is that gem_poll() expect