[RESEND] [PATCH] Fix module reference counts for loadable protocol modules

2005-09-07 Thread Frank Filz
I have been experimenting with loadable protocol modules, and ran into several issues with module reference counting. The first issue was that __module_get failed at the BUG_ON check at the top of the routine (checking that my module reference count was not zero) when I created the first socket. W

Re: [PATCH] Fix module reference counts for loadable protocol modules

2005-08-30 Thread Frank Filz
On Mon, 2005-08-29 at 16:45 -0700, Stephen Hemminger wrote: > You must check return value from try_module_get and error out > if it fails. This is critical for module unload races. Good point, and of course in such a situation, sk_alloc must free the socket. Please see the updated patch below. Th

Re: [PATCH] Fix module reference counts for loadable protocol modules

2005-08-29 Thread Stephen Hemminger
On Mon, 29 Aug 2005 16:18:20 -0700 Frank Filz <[EMAIL PROTECTED]> wrote: > I have been experimenting with loadable protocol modules, and ran into > several issues with module reference counting. > > The first issue was that __module_get failed at the BUG_ON check at the > top of the routine (chec

[PATCH] Fix module reference counts for loadable protocol modules

2005-08-29 Thread Frank Filz
I have been experimenting with loadable protocol modules, and ran into several issues with module reference counting. The first issue was that __module_get failed at the BUG_ON check at the top of the routine (checking that my module reference count was not zero) when I created the first socket. W