Re: [PATCH] Fix/Rewrite of the mipsnet driver

2007-10-28 Thread Ralf Baechle
On Sun, Oct 28, 2007 at 01:22:04PM -0700, Stephen Hemminger wrote: > > -#define MIPSNET_INTCTL_TXDONE ((uint32_t)(1 << 0)) > > -#define MIPSNET_INTCTL_RXDONE ((uint32_t)(1 << 1)) > > -#define MIPSNET_INTCTL_TESTBIT((uint32_t)(1 << 31)) > > -#define MIPSNET_INTCTL_ALLSOURCES (MIPSNET

Re: [PATCH] Fix/Rewrite of the mipsnet driver

2007-10-28 Thread Thiemo Seufer
Stephen Hemminger wrote: > On Sun, 28 Oct 2007 20:03:08 + > Thiemo Seufer <[EMAIL PROTECTED]> wrote: > > > Ralf Baechle wrote: > > > On Sun, Oct 28, 2007 at 04:38:46AM +, Thiemo Seufer wrote: > > > > > > > Hello All, > > > > > > > > currently the mipsnet driver fails after transmitting a

Re: [PATCH] Fix/Rewrite of the mipsnet driver

2007-10-28 Thread Stephen Hemminger
On Sun, 28 Oct 2007 20:03:08 + Thiemo Seufer <[EMAIL PROTECTED]> wrote: > Ralf Baechle wrote: > > On Sun, Oct 28, 2007 at 04:38:46AM +, Thiemo Seufer wrote: > > > > > Hello All, > > > > > > currently the mipsnet driver fails after transmitting a number of > > > packages because SKBs are

Re: [PATCH] Fix/Rewrite of the mipsnet driver

2007-10-28 Thread Thiemo Seufer
Ralf Baechle wrote: > On Sun, Oct 28, 2007 at 04:38:46AM +, Thiemo Seufer wrote: > > > Hello All, > > > > currently the mipsnet driver fails after transmitting a number of > > packages because SKBs are allocated but never freed. I fixed that > > and coudn't refrain from removing the most egre

Re: [PATCH] Fix/Rewrite of the mipsnet driver

2007-10-28 Thread Ralf Baechle
On Sun, Oct 28, 2007 at 04:38:46AM +, Thiemo Seufer wrote: > Hello All, > > currently the mipsnet driver fails after transmitting a number of > packages because SKBs are allocated but never freed. I fixed that > and coudn't refrain from removing the most egregious warts. > > - mipsnet.h fold

[PATCH] Fix/Rewrite of the mipsnet driver

2007-10-27 Thread Thiemo Seufer
Hello All, currently the mipsnet driver fails after transmitting a number of packages because SKBs are allocated but never freed. I fixed that and coudn't refrain from removing the most egregious warts. - mipsnet.h folded into mipsnet.c, as it doesn't provide any useful external interface. - Fr