Re: [PATCH] Eliminate some unnecessary gotos in tcp v4 hash handling

2007-04-20 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Thu, 5 Apr 2007 12:48:44 +0200 > > The compiler eliminates them anyways and this makes the code easier to read > and shorter. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Actually I won't apply this patch, ever, -ENOCOMPILE. Andi, please spare me

Re: [PATCH] Eliminate some unnecessary gotos in tcp v4 hash handling

2007-04-20 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Thu, 5 Apr 2007 12:48:44 +0200 > The compiler eliminates them anyways and this makes the code easier to read > and shorter. > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> It depends upon who you ask :-) For someone trying to verify "all code paths l

[PATCH] Eliminate some unnecessary gotos in tcp v4 hash handling

2007-04-05 Thread Andi Kleen
The compiler eliminates them anyways and this makes the code easier to read and shorter. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux-2.6.21-rc3-net/net/ipv4/tcp_ipv4.c === --- linux-2.6.21-rc3-net.orig/net/ipv4/tcp_ip