Re: [PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Patrick McHardy
Pavel Emelyanov wrote: Patrick McHardy wrote: It would be nicer to replace the entire hand-made name allocation to remove the 100 device limit. Actually, I thought the same, but fixing % in names looks like a BUG-fix for 2.6.25, while removing the hand-made name allocation looks like an en

Re: [PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Pavel Emelyanov
Patrick McHardy wrote: > Pavel Emelyanov wrote: >> Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can >> receive a pre-defined name for a device from the userspace. >> Since these drivers call the register_netdevice() after this >> (rtnl_lock is held), the device's name may contain a '%'

Re: [PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Patrick McHardy
Pavel Emelyanov wrote: Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can receive a pre-defined name for a device from the userspace. Since these drivers call the register_netdevice() after this (rtnl_lock is held), the device's name may contain a '%' character. Not sure how bad is th

[PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Pavel Emelyanov
Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can receive a pre-defined name for a device from the userspace. Since these drivers call the register_netdevice() after this (rtnl_lock is held), the device's name may contain a '%' character. Not sure how bad is this to have a device with a