Re: [PATCH] Compact sk_stream_mem_schedule() code

2007-11-19 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 17:30:59 -0200 > Em Mon, Nov 19, 2007 at 03:13:44PM +0300, Pavel Emelyanov escreveu: > > This function references sk->sk_prot->xxx for many times. > > It turned out, that there's so many code in it, that gcc > > cannot alwa

Re: [PATCH] Compact sk_stream_mem_schedule() code

2007-11-19 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 19, 2007 at 03:13:44PM +0300, Pavel Emelyanov escreveu: > This function references sk->sk_prot->xxx for many times. > It turned out, that there's so many code in it, that gcc > cannot always optimize access to sk->sk_prot's fields. > > After saving the sk->sk_prot on the stack and com

[PATCH] Compact sk_stream_mem_schedule() code

2007-11-19 Thread Pavel Emelyanov
This function references sk->sk_prot->xxx for many times. It turned out, that there's so many code in it, that gcc cannot always optimize access to sk->sk_prot's fields. After saving the sk->sk_prot on the stack and comparing disassembled code, it turned out that the function became ~10 bytes sho