Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs

2007-11-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 18:52:34 +0300 > The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s, > which looks completely bad. Similar ifdefs inside the functions > looks a bit better, but they are also not recommended to be used. > > Provide an i

Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs

2007-11-01 Thread Pavel Emelyanov
Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 01, 2007 at 06:52:34PM +0300, Pavel Emelyanov escreveu: >> The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s, >> which looks completely bad. Similar ifdefs inside the functions >> looks a bit better, but they are also not recommended to be

Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs

2007-11-01 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 01, 2007 at 06:52:34PM +0300, Pavel Emelyanov escreveu: > The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s, > which looks completely bad. Similar ifdefs inside the functions > looks a bit better, but they are also not recommended to be used. > > Provide an ifdef-ed ip_mr

[PATCH] Clean the ip_sockglue.c from some ugly ifdefs

2007-11-01 Thread Pavel Emelyanov
The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s, which looks completely bad. Similar ifdefs inside the functions looks a bit better, but they are also not recommended to be used. Provide an ifdef-ed ip_mroute_opt() helper to cleanup the code. Signed-off-by: Pavel Emelyanov <[EMAIL