From: Denis Du
Date: Wed, 21 Feb 2018 03:35:31 + (UTC)
> How is your thinking about this patch?
I cannot apply a patch which has been corrupted by your email client like
this.
Please send it properly again, plain ASCII text, and no trasnformations
by your email client.
You should send the
Hi, David:
How is your thinking about this patch?
>From b5902a4dfc709b62b704997ab64f31c9ef69a6db Mon Sep 17 00:00:00 2001
From: Denis Du
Date: Mon, 15 Jan 2018 17:26:06 -0500
Subject: [PATCH] netdev: carrier detect ok, don't turn off negotiation
Sometimes when physical lines have a just
Ok, I submit it again.
In drivers/net/wan/hdlc_ppp.c, some noise on physical line can cause the
carrier detect still ok, but the protocol will fail. So if carrier detect ok,
don't turn off protocol negotiation
This patch is against the kernel version Linux 4.15-rc8
On Tuesday, February
From: Denis Du
Date: Tue, 6 Feb 2018 15:15:28 + (UTC)
> How do you think my patch?
>
> As you see, Krzysztof think my patch is ok to be accepted.
> But if you have a better idea to fix it,I am glad to see it. Anyway, this
> issue have to be fixed.
Please resubmit it and I'll think about
Hi, David:
How do you think my patch?
As you see, Krzysztof think my patch is ok to be accepted.
But if you have a better idea to fix it,I am glad to see it. Anyway, this issue
have to be fixed.
Denis DU
On Sunday, January 28, 2018, 9:34:15 AM EST, Krzysztof Halasa
wrote:
Den
Denis Du writes:
>>From the above code, I can get that only Carrier have some change, it
> will restart the protocol by hdlc_proto_start(dev);and thus the timer,
> the previous timer expired due to protocol fail.
>
> If carrier keep no change by if (hdlc->carrier == on)
> goto carrier_exi
Ok, I check the source code again. It have nothing to do with the interrupts,
it is related how the hdlc.c is implemented.
In drivers/net/wan/hdlc.c#L108
if (hdlc->carrier == on)
goto carrier_exit; /* no change in DCD line level */
hdlc->carrier = on;
if (!hdlc->open)
The timer is supposed to be triggered by carrier detect interrupt. After remove
the line noise, the carrier detect interrupt is never triggered again, because
the carrier is always ok and it only trigger the timer once, Since the protocol
was terminated and no new interrupts happen, the link w
From: Denis Du
Date: Tue, 16 Jan 2018 16:58:25 + (UTC)
> From b5902a4dfc709b62b704997ab64f31c9ef69a6db Mon Sep 17 00:00:00 2001
> From: Denis Du
> Date: Mon, 15 Jan 2018 17:26:06 -0500
> Subject: [PATCH] netdev: carrier detect ok, don't turn off negotiation
>
> Sometimes when physical lines
In drivers/net/wan/hdlc_ppp.c, some noise on physical line can cause the
carrier detect still ok, but the protocol will fail. So if carrier detect ok,
don't turn off protocol negotiation
This patch is against the kernel version Linux 4.15-rc8From b5902a4dfc709b62b704997ab64f31c9ef69a6db Mon Sep
10 matches
Mail list logo
