Re: [PATCH] CDC-NCM: remove "connected" log message

2021-01-05 Thread Roland Dreier
> now that you put it that way, I get the merit of what you are saying. > Very well. I will submit the first set of patches. > > May I add your "Tested-by"? Yes, absolutely: Tested-by: Roland Dreier

Re: [PATCH] CDC-NCM: remove "connected" log message

2021-01-05 Thread Oliver Neukum
Am Montag, den 04.01.2021, 11:13 -0800 schrieb Roland Dreier: > > > to preserve the legacy behavior rather than changing the behavior of > > > every usbnet driver all at once? Like make a new > > > usbnet_get_link_ksettings_nonmdio and update only cdc_ncm to use it? > > > > Then I would have to t

Re: [PATCH] CDC-NCM: remove "connected" log message

2021-01-04 Thread Roland Dreier
> > to preserve the legacy behavior rather than changing the behavior of > > every usbnet driver all at once? Like make a new > > usbnet_get_link_ksettings_nonmdio and update only cdc_ncm to use it? > > Then I would have to touch them all. The problem is that the MDIO > stuff really is pretty much

Re: [PATCH] CDC-NCM: remove "connected" log message

2021-01-04 Thread Oliver Neukum
Am Donnerstag, den 31.12.2020, 10:51 -0800 schrieb Roland Dreier: > I haven't tried these patches yet but they don't look quite right to > me. inlining the first 0001 patch: OK, let's see. > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > > index 1447da1d5729..bcd17f6d6de6

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-31 Thread Roland Dreier
I haven't tried these patches yet but they don't look quite right to me. inlining the first 0001 patch: > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index 1447da1d5729..bcd17f6d6de6 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -944,7 +

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-30 Thread Oliver Neukum
Am Dienstag, den 29.12.2020, 11:50 -0800 schrieb Roland Dreier: > > I looked at them again and found that there is a way to get > > the same effect that will make maintenance easier in the long run. > > Could I send them to you later this week for testing? > > Yes, please. I have a good test setu

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-29 Thread Roland Dreier
> I looked at them again and found that there is a way to get > the same effect that will make maintenance easier in the long run. > Could I send them to you later this week for testing? Yes, please. I have a good test setup now so I can easily try out patches. Thanks, Roland

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-29 Thread Oliver Neukum
Am Montag, den 28.12.2020, 23:56 -0800 schrieb Roland Dreier: > > Applied to net and queued for LTS, thanks! > > Thanks - is Oliver's series of 3 patches that get rid of the other > half of the log spam also on the way upstream? Hi, I looked at them again and found that there is a way to get the

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-28 Thread Roland Dreier
> Applied to net and queued for LTS, thanks! Thanks - is Oliver's series of 3 patches that get rid of the other half of the log spam also on the way upstream? - R.

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-28 Thread Jakub Kicinski
On Thu, 24 Dec 2020 08:53:52 +0100 Greg KH wrote: > On Wed, Dec 23, 2020 at 07:21:16PM -0800, Roland Dreier wrote: > > The cdc_ncm driver passes network connection notifications up to > > usbnet_link_change(), which is the right place for any logging. > > Remove the netdev_info() duplicating this f

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-23 Thread Greg KH
On Wed, Dec 23, 2020 at 07:21:16PM -0800, Roland Dreier wrote: > The cdc_ncm driver passes network connection notifications up to > usbnet_link_change(), which is the right place for any logging. > Remove the netdev_info() duplicating this from the driver itself. > > This stops devices such as my

[PATCH] CDC-NCM: remove "connected" log message

2020-12-23 Thread Roland Dreier
The cdc_ncm driver passes network connection notifications up to usbnet_link_change(), which is the right place for any logging. Remove the netdev_info() duplicating this from the driver itself. This stops devices such as my "TRENDnet USB 10/100/1G/2.5G LAN" (ID 20f4:e02b) adapter from spamming th