Re: [PATCH] 3c59x: sparse warning fix

2007-09-12 Thread Steffen Klassert
On Wed, Sep 05, 2007 at 03:23:59PM +0100, Stephen Hemminger wrote: > --- a/drivers/net/3c59x.c 2007-09-05 15:15:16.0 +0100 > +++ b/drivers/net/3c59x.c 2007-09-05 15:16:29.0 +0100 > @@ -1122,7 +1122,7 @@ static int __devinit vortex_probe1(struc >

Re: [PATCH] 3c59x: sparse warning fix

2007-09-05 Thread Stephen Hemminger
On Wed, 05 Sep 2007 09:57:05 -0700 Joe Perches <[EMAIL PROTECTED]> wrote: > On Wed, 2007-09-05 at 15:23 +0100, Stephen Hemminger wrote: > > --- a/drivers/net/3c59x.c 2007-09-05 15:15:16.0 +0100 > > +++ b/drivers/net/3c59x.c 2007-09-05 15:16:29.0 +0100 > > @@ -1122,7 +1122,7 @@

Re: [PATCH] 3c59x: sparse warning fix

2007-09-05 Thread Francois Romieu
Joe Perches <[EMAIL PROTECTED]> : [...] > Shouldn't this be: > > if (pkt_len < rx_copybreak) { > skb = dev_alloc_skb(pkt_len + 2); > if (!skb) { > bad_news! (like the refill rx ring buffers block) > } It is not that bad a news:

Re: [PATCH] 3c59x: sparse warning fix

2007-09-05 Thread Joe Perches
On Wed, 2007-09-05 at 15:23 +0100, Stephen Hemminger wrote: > --- a/drivers/net/3c59x.c 2007-09-05 15:15:16.0 +0100 > +++ b/drivers/net/3c59x.c 2007-09-05 15:16:29.0 +0100 > @@ -1122,7 +1122,7 @@ static int __devinit vortex_probe1(struc >

[PATCH] 3c59x: sparse warning fix

2007-09-05 Thread Stephen Hemminger
--- a/drivers/net/3c59x.c 2007-09-05 15:15:16.0 +0100 +++ b/drivers/net/3c59x.c 2007-09-05 15:16:29.0 +0100 @@ -1122,7 +1122,7 @@ static int __devinit vortex_probe1(struc + sizeof(struct boom_tx_desc) * TX_RING_SIZE,