Re: [PATCH] [v3] spidernet : add improved phy support

2007-02-12 Thread Linas Vepstas
Tested the patch, it works for me. Thus I'll attach a pre-emptive Acked-by: Linas Vepstas <[EMAIL PROTECTED]> However, some quibbbles, which I think would be nice to see fixed: On Mon, Feb 12, 2007 at 09:35:34PM +0100, Jens Osterkamp wrote: > > Index: linux-2.6.20/drivers/net/sungem_phy.c > =

Re: [PATCH] [v3] spidernet : add improved phy support

2007-02-12 Thread Benjamin Herrenschmidt
> +static int bcm5461_enable_fiber(struct mii_phy* phy, int autoneg) > +{ > + /* select fiber mode, enable 1000 base-X registers */ > + phy_write(phy, MII_NCONFIG, 0xfc0b); > + > + if (autoneg) { > + /* enable fiber with no autonegotiation */ > + phy_write(phy,

[PATCH] [v3] spidernet : add improved phy support

2007-02-12 Thread Jens Osterkamp
This version moves the medium variable to the card specific structure and changes the GMII_* to BCM54XX_* #defines. This patch adds improved version of enable_fiber for both the 5421 and the 5461 phy. It is now possible to specify with these wether you want autonegotiation or not. This is needed f