Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-10-16 Thread Kalle Valo
Leon Romanovsky writes: > On Wed, Sep 30, 2020 at 12:11:24PM +0200, Johannes Berg wrote: >> On Wed, 2020-09-30 at 12:55 +0300, Leon Romanovsky wrote: >> > On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: >> > > Leon Romanovsky writes: >> > > >> > > > > diff --git a/drivers/net/wireles

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 12:11:24PM +0200, Johannes Berg wrote: > On Wed, 2020-09-30 at 12:55 +0300, Leon Romanovsky wrote: > > On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > > > Leon Romanovsky writes: > > > > > > > > diff --git a/drivers/net/wireless/purelifi/Kconfig > > > > b/driv

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Johannes Berg
On Wed, 2020-09-30 at 12:55 +0300, Leon Romanovsky wrote: > On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > > Leon Romanovsky writes: > > > > > > diff --git a/drivers/net/wireless/purelifi/Kconfig > > > b/drivers/net/wireless/purelifi/Kconfig > > > > new file mode 100644 > > > > ind

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 11:05:49AM +0300, Kalle Valo wrote: > Leon Romanovsky writes: > > >> --- /dev/null > >> +++ b/drivers/net/wireless/purelifi/Kconfig > >> @@ -0,0 +1,38 @@ > >> +# SPDX-License-Identifier: GPL-2.0 > >> +config WLAN_VENDOR_PURELIFI > >> + bool "pureLiFi devices" > >> + defau

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > Leon Romanovsky writes: > > >> diff --git a/drivers/net/wireless/purelifi/Kconfig > > b/drivers/net/wireless/purelifi/Kconfig > >> new file mode 100644 > >> index ..ff05eaf0a8d4 > >> --- /dev/null > >> +++ b/drivers/net/wire

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Kalle Valo
Leon Romanovsky writes: >> --- /dev/null >> +++ b/drivers/net/wireless/purelifi/Kconfig >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +config WLAN_VENDOR_PURELIFI >> +bool "pureLiFi devices" >> +default y > > "N" is preferred default. > >> +help >> + If you have a

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Kalle Valo
Leon Romanovsky writes: >> diff --git a/drivers/net/wireless/purelifi/Kconfig > b/drivers/net/wireless/purelifi/Kconfig >> new file mode 100644 >> index ..ff05eaf0a8d4 >> --- /dev/null >> +++ b/drivers/net/wireless/purelifi/Kconfig >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: GP

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-29 Thread Srinivasan Raju
> I stopped here. > > Thanks Thanks for your comments Leon, I will resubmit after the changes Thanks Srini

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-29 Thread Leon Romanovsky
On Mon, Sep 28, 2020 at 03:49:49PM +0530, Srinivasan Raju wrote: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices, which provide lightweight, highspeed secure and > fully networked wireless communications via light. > > This driver implementation has been bas

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-28 Thread Srinivasan Raju
> Didn't look at the rest Thanks for your comments Joe, I will refactor the code for clarity, remove redundancy and address your comments. Regards Srini

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-28 Thread Joe Perches
On Mon, 2020-09-28 at 15:49 +0530, Srinivasan Raju wrote: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices, which provide lightweight, highspeed secure and > fully networked wireless communications via light. trivial notes: > diff --git a/drivers/net/wirele

[PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-28 Thread Srinivasan Raju
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices, which provide lightweight, highspeed secure and fully networked wireless communications via light. This driver implementation has been based on the zd1211rw driver Driver is based on 802.11 softMAC Architecture