Re: [PATCH] [v2] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-11-20 Thread Florian Fainelli
On 11/20/2016 08:08 AM, Timur Tabi wrote: > On Mon, Nov 14, 2016 at 12:35 PM, Florian Fainelli > wrote: >> if (!(drv->features & (SUPPORTED_Pause | SUPPORTED_AsymPause)) >> phydev->supported |= SUPPORTED_Pause | SUPPORTED_AsymPause; > > How about, if either bit is set in drv->features,

Re: [PATCH] [v2] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-11-20 Thread Timur Tabi
On Mon, Nov 14, 2016 at 12:35 PM, Florian Fainelli wrote: > if (!(drv->features & (SUPPORTED_Pause | SUPPORTED_AsymPause)) > phydev->supported |= SUPPORTED_Pause | SUPPORTED_AsymPause; How about, if either bit is set in drv->features, then assume the phy driver really knows what it's doin

Re: [PATCH] [v2] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-11-14 Thread Florian Fainelli
On 11/10/2016 03:46 PM, Timur Tabi wrote: > Instead of having individual PHY drivers set the SUPPORTED_Pause and > SUPPORTED_Asym_Pause flags, phylib itself should set those flags. > During autonegotiation, the PHYs will determine whether to enable > pause frame support. > > Pause frames are a fea

Re: [PATCH] [v2] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-11-14 Thread David Miller
From: Timur Tabi Date: Thu, 10 Nov 2016 17:46:01 -0600 > Instead of having individual PHY drivers set the SUPPORTED_Pause and > SUPPORTED_Asym_Pause flags, phylib itself should set those flags. > During autonegotiation, the PHYs will determine whether to enable > pause frame support. > > Pause f

[PATCH] [v2] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-11-10 Thread Timur Tabi
Instead of having individual PHY drivers set the SUPPORTED_Pause and SUPPORTED_Asym_Pause flags, phylib itself should set those flags. During autonegotiation, the PHYs will determine whether to enable pause frame support. Pause frames are a feature that is supported by the MAC. It is the MAC that