Re: [PATCH] [IrDA] Use alloc_skb() in IrDA TX path

2006-07-18 Thread Samuel Ortiz
On Tue, Jul 18, 2006 at 03:38:31PM -0700, David Miller wrote: > As followups it would be nice to: > 2) Change these 64 and 128 constant sizes to something with >a name. Yes, this is not nice and I was already working on it. I decided to send this patch soon as I didn't want to hold Christoph's

[PATCH] [IrDA] Use alloc_skb() in IrDA TX path

2006-07-18 Thread Samuel Ortiz
Hi Dave, As pointed out by Christoph Hellwig, dev_alloc_skb() is not intended to be used for allocating TX sk_buff. The IrDA stack was exclusively calling dev_alloc_skb() on the TX path, and this patch fixes that. Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> --- net/irda/af_irda.c

Re: [PATCH] [IrDA] Use alloc_skb() in IrDA TX path

2006-07-18 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Wed, 19 Jul 2006 08:13:31 +0300 > As pointed out by Christoph Hellwig, dev_alloc_skb() is not intended to be > used for allocating TX sk_buff. The IrDA stack was exclusively calling > dev_alloc_skb() on the TX path, and this patch fixes that. > > Signe