Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-06 Thread Mitsuru Chinen
On Thu, 6 Dec 2007 09:47:33 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On 06-12-2007 09:14, Mitsuru Chinen wrote: > > On Thu, 6 Dec 2007 08:49:47 +0100 > > Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > >> On 06-12-2007 07:31, Mitsuru Chinen wrote: > >>> IPv4 stack doesn't reply any ICM

Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-06 Thread Jarek Poplawski
On 06-12-2007 09:14, Mitsuru Chinen wrote: > On Thu, 6 Dec 2007 08:49:47 +0100 > Jarek Poplawski <[EMAIL PROTECTED]> wrote: > >> On 06-12-2007 07:31, Mitsuru Chinen wrote: >>> IPv4 stack doesn't reply any ICMP destination unreachable message >>> with net unreachable code when IP detagrams are bein

Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-06 Thread Mitsuru Chinen
On Thu, 6 Dec 2007 08:49:47 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On 06-12-2007 07:31, Mitsuru Chinen wrote: > > IPv4 stack doesn't reply any ICMP destination unreachable message > > with net unreachable code when IP detagrams are being discarded > > because of no route could be found

Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-06 Thread Rami Rosen
Hello, Jarek, I am sorry, but I think I am nor sure I underatand exactly what you mean when you say: "It overrides err codes from fib_lookup, where such decisions should be made." What is incorrect here ? There are two lines added in this patch; IP_INC_STATS_BH(IPSTATS_MIB_INNOROUTES); and err

Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-05 Thread Jarek Poplawski
On 06-12-2007 07:31, Mitsuru Chinen wrote: > IPv4 stack doesn't reply any ICMP destination unreachable message > with net unreachable code when IP detagrams are being discarded > because of no route could be found in the forwarding path. > Incidentally, IPv6 stack replies such ICMPv6 message in the

Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-05 Thread David Miller
From: Mitsuru Chinen <[EMAIL PROTECTED]> Date: Thu, 6 Dec 2007 15:31:05 +0900 > IPv4 stack doesn't reply any ICMP destination unreachable message > with net unreachable code when IP detagrams are being discarded > because of no route could be found in the forwarding path. > Incidentally, IPv6 stac

[PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-05 Thread Mitsuru Chinen
IPv4 stack doesn't reply any ICMP destination unreachable message with net unreachable code when IP detagrams are being discarded because of no route could be found in the forwarding path. Incidentally, IPv6 stack replies such ICMPv6 message in the similar situation. Signed-off-by: Mitsuru Chinen