Re: [PATCH] [IPV6] Defer IPv6 device initialization until a valid qdisc is specified

2007-10-10 Thread David Miller
From: Mitsuru Chinen <[EMAIL PROTECTED]> Date: Tue, 9 Oct 2007 16:21:58 +0900 > To judge the timing for DAD, netif_carrier_ok() is used. However, > there is a possibility that dev->qdisc stays noop_qdisc even if > netif_carrier_ok() returns true. In that case, DAD NS is not sent out. > We need to

Re: [PATCH] [IPV6] Defer IPv6 device initialization until a valid qdisc is specified

2007-10-09 Thread Herbert Xu
YOSHIFUJI Hideaki / <[EMAIL PROTECTED]> wrote: > > We'd really like to do our best to avoid such random failures > even if it may/can not be perfect. OK I see your point of view but there's got to be a better way than this. As it is your tests will fail randomly anyway if you do it

Re: [PATCH] [IPV6] Defer IPv6 device initialization until a valid qdisc is specified

2007-10-09 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Wed, 10 Oct 2007 09:32:35 +0800), Herbert Xu <[EMAIL PROTECTED]> says: > Mitsuru Chinen <[EMAIL PROTECTED]> wrote: > > To judge the timing for DAD, netif_carrier_ok() is used. However, > > there is a possibility that dev->qdisc stays noop_qdisc even if >

Re: [PATCH] [IPV6] Defer IPv6 device initialization until a valid qdisc is specified

2007-10-09 Thread Herbert Xu
Mitsuru Chinen <[EMAIL PROTECTED]> wrote: > To judge the timing for DAD, netif_carrier_ok() is used. However, > there is a possibility that dev->qdisc stays noop_qdisc even if > netif_carrier_ok() returns true. In that case, DAD NS is not sent out. > We need to defer the IPv6 device initialization

[PATCH] [IPV6] Defer IPv6 device initialization until a valid qdisc is specified

2007-10-09 Thread Mitsuru Chinen
To judge the timing for DAD, netif_carrier_ok() is used. However, there is a possibility that dev->qdisc stays noop_qdisc even if netif_carrier_ok() returns true. In that case, DAD NS is not sent out. We need to defer the IPv6 device initialization until a valid qdisc is specified. Signed-off-by: