Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-23 Thread Joonwoo Park
2008/1/24, Eric Dumazet <[EMAIL PROTECTED]>: > > Unfortunatly, your patch doesnt work on CONFIG_SMP=n (softirq will be disabled > for the whole scan of table) > > Also, some machines around there have 2^22 slots in hash table, and NR_CPUS=4, > so softirqs will be disabled for a too long time. > > P

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-23 Thread Eric Dumazet
[EMAIL PROTECTED] a écrit : On Mon, Jan 21, 2008 at 02:40:43AM -0800, David Miller wrote: From: Joonwoo Park <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 00:08:57 +0900 The rt_run_flush() can be stucked if it was called while netdev is on the high load. It's possible when pushing rtable to rt_h

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-22 Thread joonwpark81
On Mon, Jan 21, 2008 at 02:40:43AM -0800, David Miller wrote: > From: Joonwoo Park <[EMAIL PROTECTED]> > Date: Tue, 22 Jan 2008 00:08:57 +0900 > > > The rt_run_flush() can be stucked if it was called while netdev is on the > > high load. > > It's possible when pushing rtable to rt_hash is faster

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-21 Thread Eric Dumazet
David Miller a écrit : From: Joonwoo Park <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 00:08:57 +0900 The rt_run_flush() can be stucked if it was called while netdev is on the high load. It's possible when pushing rtable to rt_hash is faster than pulling from it. The commands 'ifconfig up or if

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-21 Thread David Miller
From: Joonwoo Park <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 00:08:57 +0900 > The rt_run_flush() can be stucked if it was called while netdev is on the > high load. > It's possible when pushing rtable to rt_hash is faster than pulling > from it. > > The commands 'ifconfig up or ifconfig mtu' an

[PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-20 Thread Joonwoo Park
The rt_run_flush() can be stucked if it was called while netdev is on the high load. It's possible when pushing rtable to rt_hash is faster than pulling from it. The commands 'ifconfig up or ifconfig mtu' and netif_carrier_on() can introduce soft lockup like this: [ 363.528001] BUG: soft lockup