Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

2008-01-30 Thread David Miller
From: Oliver Neukum <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 09:25:12 +0100 > Now suppose somebody needs to change locking. He'll have to convert > it back. IMHO a conditional return is worse than "goto clearly_named_label" I totally agree. -- To unsubscribe from this list: send the line "unsub

Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

2008-01-30 Thread Andi Kleen
Oliver Neukum <[EMAIL PROTECTED]> writes: > Am Mittwoch, 30. Januar 2008 09:01:10 schrieb Andi Kleen: >> >> gcc does not generate different code for return foo vs bar = foo; goto x; >> x: return bar; So convert it all to direct returns for better readability. > > Now suppose somebody needs to cha

Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

2008-01-30 Thread Oliver Neukum
Am Mittwoch, 30. Januar 2008 09:01:10 schrieb Andi Kleen: > > gcc does not generate different code for return foo vs bar = foo; goto x; > x: return bar; So convert it all to direct returns for better readability. Now suppose somebody needs to change locking. He'll have to convert it back. IMHO a

[PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

2008-01-30 Thread Andi Kleen
gcc does not generate different code for return foo vs bar = foo; goto x; x: return bar; So convert it all to direct returns for better readability. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux/net/ipv4/tcp_ipv4.c ===