Re: [PATCH][next] rtw88: 8723d: fix incorrect setting of ldo_pwr

2020-05-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > Currently ldo_pwr has the LDO25 voltage bits set to zero and then > it is overwritten with the new voltage setting. The assignment > looks incorrect, it should be bit-wise or'ing in the new voltage > setting rather than a direct assignment. > > Addr

Re: [PATCH][next] rtw88: 8723d: fix incorrect setting of ldo_pwr

2020-05-14 Thread Pkshih
On Thu, 2020-05-14 at 18:13 +, Colin King wrote: > From: Colin Ian King > > Currently ldo_pwr has the LDO25 voltage bits set to zero and then > it is overwritten with the new voltage setting. The assignment > looks incorrect, it should be bit-wise or'ing in the new voltage > setting rather th

[PATCH][next] rtw88: 8723d: fix incorrect setting of ldo_pwr

2020-05-14 Thread Colin King
From: Colin Ian King Currently ldo_pwr has the LDO25 voltage bits set to zero and then it is overwritten with the new voltage setting. The assignment looks incorrect, it should be bit-wise or'ing in the new voltage setting rather than a direct assignment. Addresses-Coverity: ("Unused value") Fix