Re: [PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-08 Thread Saeed Mahameed
On Tue, 2019-03-05 at 19:03 -0800, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 5 Mar 2019 22:21:39 + > > > On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote: > > > On Sun, Mar 03, 2019 at 03:20:57PM +, Roi Dayan wrote: > > > > On 02/03/2019 21:39, Gustavo A. R. Silva wr

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-05 Thread David Miller
From: Saeed Mahameed Date: Tue, 5 Mar 2019 22:21:39 + > On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote: >> On Sun, Mar 03, 2019 at 03:20:57PM +, Roi Dayan wrote: >> > >> > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: >> > > Remove redundant assignment to tun_entropy->enabled

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-05 Thread Saeed Mahameed
On Mon, 2019-03-04 at 08:26 +0200, Leon Romanovsky wrote: > On Sun, Mar 03, 2019 at 03:20:57PM +, Roi Dayan wrote: > > > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > > > Remove redundant assignment to tun_entropy->enabled. > > > > > > Addesses-Coverity-ID: 1477328 ("Unused value") > >

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-03 Thread Leon Romanovsky
On Sun, Mar 03, 2019 at 03:20:57PM +, Roi Dayan wrote: > > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > > Remove redundant assignment to tun_entropy->enabled. > > > > Addesses-Coverity-ID: 1477328 ("Unused value") > > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunne

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-03 Thread Eli Britstein
Reviewed-by: Eli Britstein On 3/3/2019 5:20 PM, Roi Dayan wrote: > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: >> Remove redundant assignment to tun_entropy->enabled. >> >> Addesses-Coverity-ID: 1477328 ("Unused value") >> Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tun

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-03 Thread Roi Dayan
On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > Remove redundant assignment to tun_entropy->enabled. > > Addesses-Coverity-ID: 1477328 ("Unused value") > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel > entropy calculation") the commit doesn't fix any real issue but

[PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-02 Thread Gustavo A. R. Silva
Remove redundant assignment to tun_entropy->enabled. Addesses-Coverity-ID: 1477328 ("Unused value") Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 ++-