Re: [PATCH][next] batman-adv: don't pass a NULL hard_iface to batadv_hardif_put

2018-03-26 Thread Simon Wunderlich
Hi, this looks good. David, would you pick this patch directly? Otherwise, I can send a pull request, but right now we would only have this single patch for net-next. Acked-by: Simon Wunderlich Acked-by: Sven Eckelmann (just discussed with Sven offline) Thank you, Simon On Friday, Mar

Re: [B.A.T.M.A.N.] [PATCH][next] batman-adv: don't pass a NULL hard_iface to batadv_hardif_put

2018-03-24 Thread Sven Eckelmann
On Freitag, 23. März 2018 23:53:50 CET Colin King wrote: > From: Colin Ian King > > In the case where hard_iface is NULL, the error path may pass a null > pointer to batadv_hardif_put causing a null pointer dereference error. > Avoid this by only calling the function if hard_iface not null. > >

[PATCH][next] batman-adv: don't pass a NULL hard_iface to batadv_hardif_put

2018-03-23 Thread Colin King
From: Colin Ian King In the case where hard_iface is NULL, the error path may pass a null pointer to batadv_hardif_put causing a null pointer dereference error. Avoid this by only calling the function if hard_iface not null. Detected by CoverityScan, CID#1466456 ("Explicit null dereferenced")