Re: [PATCH][net-next] svcrdma: fix an incorrect check on -E2BIG and -EINVAL

2017-07-13 Thread J. Bruce Fields
On Thu, Jul 13, 2017 at 01:53:10PM -0400, Chuck Lever wrote: > > > On Jul 13, 2017, at 1:51 PM, Colin King wrote: > > > > From: Colin Ian King > > > > The current check will always be true and will always jump to > > err1, this looks dubious to me. I believe && should be used > > instead of ||

Re: [PATCH][net-next] svcrdma: fix an incorrect check on -E2BIG and -EINVAL

2017-07-13 Thread Chuck Lever
> On Jul 13, 2017, at 1:51 PM, Colin King wrote: > > From: Colin Ian King > > The current check will always be true and will always jump to > err1, this looks dubious to me. I believe && should be used > instead of ||. > > Detected by CoverityScan, CID#1450120 ("Logically Dead Code") > > Fix

[PATCH][net-next] svcrdma: fix an incorrect check on -E2BIG and -EINVAL

2017-07-13 Thread Colin King
From: Colin Ian King The current check will always be true and will always jump to err1, this looks dubious to me. I believe && should be used instead of ||. Detected by CoverityScan, CID#1450120 ("Logically Dead Code") Fixes: 107c1d0a991a ("svcrdma: Avoid Send Queue overflow") Signed-off-by: C