Re: [PATCH][net-next] esp6: fix incorrect null pointer check on xo

2017-04-18 Thread Steffen Klassert
On Tue, Apr 18, 2017 at 01:12:53PM -0400, David Miller wrote: > From: Colin King > Date: Tue, 18 Apr 2017 15:06:53 +0100 > > Trimming the CC: list down to something that actually makes > sense. > > > From: Colin Ian King > > > > The check for xo being null is incorrect, currently it is checkin

Re: [PATCH][net-next] esp6: fix incorrect null pointer check on xo

2017-04-18 Thread Dan Carpenter
It's in Steffen's tree, not the networking tree and he's not CC'd. You should really be adding Fixes tags because it helps to ensure you CC the guilty parties. regards, dan carpenter

Re: [PATCH][net-next] esp6: fix incorrect null pointer check on xo

2017-04-18 Thread David Miller
From: Colin King Date: Tue, 18 Apr 2017 15:06:53 +0100 Trimming the CC: list down to something that actually makes sense. > From: Colin Ian King > > The check for xo being null is incorrect, currently it is checking > for non-null, it should be checking for null. > > Detected with CoveritySca

[PATCH][net-next] esp6: fix incorrect null pointer check on xo

2017-04-18 Thread Colin King
From: Colin Ian King The check for xo being null is incorrect, currently it is checking for non-null, it should be checking for null. Detected with CoverityScan, CID#1429349 ("Dereference after null check") Signed-off-by: Colin Ian King --- net/ipv6/esp6_offload.c | 2 +- 1 file changed, 1 in