Re: [PATCH][XFRM] export SAD info

2007-04-27 Thread jamal
On Thu, 2007-26-04 at 14:18 -0700, David Miller wrote: > I wouldn't mind if it actually helped anything. > > The SMP cache line transactions are more expensive than the > execution of the code blocks they are protecting. rwlock's > rarely help, and when they do (the execution path is more > expe

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Thu, 26 Apr 2007 09:10:10 -0400 > I would have liked to just do a read_lock_bh when retrieving the table > metadata; however, the state table lock is defined as DEFINE_SPINLOCK > unlike the policy table which is defined as DEFINE_RWLOCK. > Any objection to cha

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Thu, 26 Apr 2007 08:55:54 -0400 > Here's a missing bit to get in sync with latest net-2.6 Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ke

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread jamal
On Thu, 2007-26-04 at 00:18 -0700, David Miller wrote: > From: jamal <[EMAIL PROTECTED]> > > Would it make sense to have those vars as u32 instead of unsigned int? > > I'm ambivalent, "unsigned int" happens to be 32-bit on every platform. > So changing it would cause no harm :-) If unsigned int

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread jamal
Thanks Dave. Here's a missing bit to get in sync with latest net-2.6 I will send you the policy side sometime tonight or tommorow. cheers, jamal [XFRM] missing bits to SAD info This brings the SAD info in sync with net-2.6.22/net-2.6 Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- comm

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Wed, 25 Apr 2007 11:54:50 -0400 > That patch has xfrm_state_num being mucked with; just ignore that bit. > I need to send a patch against net-2.6.22 and i will clean that up - > just need some feedback. > > Would it make sense to have those vars as u32 instea

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Wed, 25 Apr 2007 11:42:41 -0400 > [XFRM] export SAD info > > On a system with a lot of SAs, counting SAD entries chews useful > CPU time since you need to dump the whole SAD to user space; > i.e something like ip xfrm state ls | grep -i src | wc -l > I have s

Re: [PATCH][XFRM] export SAD info

2007-04-25 Thread jamal
That patch has xfrm_state_num being mucked with; just ignore that bit. I need to send a patch against net-2.6.22 and i will clean that up - just need some feedback. Would it make sense to have those vars as u32 instead of unsigned int? cheers, jamal - To unsubscribe from this list: send the lin

[PATCH][XFRM] export SAD info

2007-04-25 Thread jamal
Dave, Something ive been meaning to do since you made the hash changes. I will be doing one also for policy. Against latest Linus tree because i am having strange challenges syncing net-2.6.22. cheers, jamal [XFRM] export SAD info On a system with a lot of SAs, counting SAD entries chews useful