Re: [PATCH][VLAN] Lost rtnl_unlock() in vlan_ioctl()

2007-12-06 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 14:59:24 +0100 > Pavel Emelyanov wrote: > > The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability > > doesn't release the rtnl lock. > > > Thanks Pavel. I somehow recall that we already fixed this > one, but can't find th

Re: [PATCH][VLAN] Lost rtnl_unlock() in vlan_ioctl()

2007-12-06 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 14:59:24 +0100 Pavel Emelyanov wrote: The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability doesn't release the rtnl lock. Thanks Pavel. I somehow recall that we already fixed this one, but can't f

Re: [PATCH][VLAN] Lost rtnl_unlock() in vlan_ioctl()

2007-12-06 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 14:59:24 +0100 > Pavel Emelyanov wrote: > > The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability > > doesn't release the rtnl lock. > > > Thanks Pavel. I somehow recall that we already fixed this > one, but can't find th

Re: [PATCH][VLAN] Lost rtnl_unlock() in vlan_ioctl()

2007-12-06 Thread Patrick McHardy
Pavel Emelyanov wrote: The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability doesn't release the rtnl lock. Thanks Pavel. I somehow recall that we already fixed this one, but can't find the patch :) Dave, please apply. -- To unsubscribe from this list: send the line "unsubscribe net

[PATCH][VLAN] Lost rtnl_unlock() in vlan_ioctl()

2007-12-06 Thread Pavel Emelyanov
The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability doesn't release the rtnl lock. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index 6567213..5b18315 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -776,7 +776,7 @@ s