Re: [PATCH][V2] flow dissector: check if arp_eth is null rather than arp

2017-01-16 Thread David Miller
From: Colin King Date: Fri, 13 Jan 2017 18:48:20 + > From: Colin Ian King > > arp is being checked instead of arp_eth to see if the call to > __skb_header_pointer failed. Fix this by checking arp_eth is > null instead of arp. Also fix to use length hlen rather than > hlen - sizeof(_arp);

Re: [PATCH][V2] flow dissector: check if arp_eth is null rather than arp

2017-01-13 Thread Eric Dumazet
On Fri, 2017-01-13 at 18:48 +, Colin King wrote: > From: Colin Ian King > > arp is being checked instead of arp_eth to see if the call to > __skb_header_pointer failed. Fix this by checking arp_eth is > null instead of arp. Also fix to use length hlen rather than > hlen - sizeof(_arp); than

[PATCH][V2] flow dissector: check if arp_eth is null rather than arp

2017-01-13 Thread Colin King
From: Colin Ian King arp is being checked instead of arp_eth to see if the call to __skb_header_pointer failed. Fix this by checking arp_eth is null instead of arp. Also fix to use length hlen rather than hlen - sizeof(_arp); thanks to Eric Dumazet for spotting this latter issue. CoverityScan