Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status

2017-05-11 Thread David Miller
From: Colin King Date: Thu, 11 May 2017 19:29:40 +0100 > From: Colin Ian King > > The error status err is initialized as zero and then being checked > several times to see if it is less than zero even when it has not > been updated. It may seem that the err should be assigned to the > return c

Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status

2017-05-11 Thread Pavel Belous
On 11.05.2017 21:29, Colin King wrote: From: Colin Ian King The error status err is initialized as zero and then being checked several times to see if it is less than zero even when it has not been updated. It may seem that the err should be assigned to the return code of the call to the var

Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status

2017-05-11 Thread Lino Sanfilippo
Hi, On 11.05.2017 20:29, Colin King wrote: > From: Colin Ian King > > The error status err is initialized as zero and then being checked > several times to see if it is less than zero even when it has not > been updated. It may seem that the err should be assigned to the > return code of the ca

[PATCH][V2] ethernet: aquantia: remove redundant checks on error status

2017-05-11 Thread Colin King
From: Colin Ian King The error status err is initialized as zero and then being checked several times to see if it is less than zero even when it has not been updated. It may seem that the err should be assigned to the return code of the call to the various *offload_en_set calls and then we chec