Re: [PATCH][PKTGEN] Fix double unlock of xfrm_state->lock

2007-11-19 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 12:47:00 +0300 > The pktgen_output_ipsec() function can unlock this lock twice > due to merged error and plain paths. Remove one of the calls > to spin_unlock. > > Other possible solution would be to place "return 0" right > after

Re: [PATCH][PKTGEN] Fix double unlock of xfrm_state->lock

2007-11-19 Thread jamal
On Mon, 2007-19-11 at 12:47 +0300, Pavel Emelyanov wrote: > The pktgen_output_ipsec() function can unlock this lock twice > due to merged error and plain paths. Remove one of the calls > to spin_unlock. Good catch. Acked-by: Jamal Hadi Salim <[EMAIL PROTECTED]> cheers, jamal - To unsubscribe fro

[PATCH][PKTGEN] Fix double unlock of xfrm_state->lock

2007-11-19 Thread Pavel Emelyanov
The pktgen_output_ipsec() function can unlock this lock twice due to merged error and plain paths. Remove one of the calls to spin_unlock. Other possible solution would be to place "return 0" right after the first unlock, but at this place the err is known to be 0, so these solutions are the sam