Re: [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-18 Thread Andy Whitcroft
The check then is to see if a non {}'d block has no statements in it if the ifdef is null. Hmmm. May be possible. Will think on it. if (err) +#ifdef CONFIG_GFAR_NAPI napi_disable(&priv->napi); +#endif -apw - To unsubscribe from this list: send the line "unsubscribe netd

Re: [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-17 Thread Jeff Garzik
Anton Vorontsov wrote: Erroneous #ifdef introduced by 293c8513398657f6263fcdb03c87f2760cf61be4 causing NAPI-less ethernet malfunctioning. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line

[PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-17 Thread Anton Vorontsov
Erroneous #ifdef introduced by 293c8513398657f6263fcdb03c87f2760cf61be4 causing NAPI-less ethernet malfunctioning. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- if (...) #if ...; #endif good candidate for checkpatch? drivers/net