Re: [PATCH][NEIGH] Fix race between neigh_parms_release and neightbl_fill_parms

2008-01-19 Thread Andrey Rahmatullin
This patch causes messages like 'unregister_netdevice: waiting for ppp0 to become free. Usage count = 1' when I try 'ifdown ppp0'. This happens in all kernel versions containing this commit and doesn't happen in 2.6.24-rc8 with this commit reverted. -- WBR, wRAR (ALT Linux Team) signature.asc D

Re: [PATCH][NEIGH] Fix race between neigh_parms_release and neightbl_fill_parms

2008-01-10 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008 13:56:53 +0300 > The neightbl_fill_parms() is called under the write-locked > tbl->lock and accesses the parms->dev. The negh_parm_release() > calls the dev_put(parms->dev) without this lock. This > creates a tiny race window on whi

[PATCH][NEIGH] Fix race between neigh_parms_release and neightbl_fill_parms

2008-01-10 Thread Pavel Emelyanov
The neightbl_fill_parms() is called under the write-locked tbl->lock and accesses the parms->dev. The negh_parm_release() calls the dev_put(parms->dev) without this lock. This creates a tiny race window on which the parms contains potentially stale dev pointer. To fix this race it's enough to mov