Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-28 Thread Jeff Garzik
Overall, looks pretty clean, good job! Comments: 1) [major issue] Don't take and release a heavy lock on every single RX packet. 2) remove net_device_stats from private structure, and use net_device::stats 3) rx_ring_size should not be a module param, since that should be supported via etht

[PATCH][MIPS][7/7] AR7: ethernet

2007-09-20 Thread Matteo Croce
Driver for the cpmac 100M ethernet driver. Jeff, here is the meat ;) Signed-off-by: Matteo Croce <[EMAIL PROTECTED]> Signed-off-by: Eugene Konev <[EMAIL PROTECTED]> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 6a0863e..28ba0dc 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kco

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-13 Thread Ralf Baechle
On Thu, Sep 13, 2007 at 02:42:46AM +0100, Thiemo Seufer wrote: > > All struct members here are sized such that there is no padding needed, so > > the packed attribute doesn't buy you anything - unless of course the > > entire structure is missaligned but I don't see how that would be possible > >

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-12 Thread Thiemo Seufer
Ralf Baechle wrote: > On Sat, Sep 08, 2007 at 02:23:00AM +0200, Matteo Croce wrote: [snip] > > +/* Register definitions */ > > +struct cpmac_control_regs { > > + u32 revision; > > + u32 control; > > + u32 teardown; > > + u32 unused; > > +} __attribute__ ((packed)); > > + > > +struct cpmac_i

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-12 Thread Ralf Baechle
On Sat, Sep 08, 2007 at 02:23:00AM +0200, Matteo Croce wrote: > Driver for the cpmac 100M ethernet driver. > It works fine disabling napi support, enabling it gives a kernel panic > when the first IPv6 packet has to be forwarded. > Other than that works fine. > > Signed-off-by: Matteo Croce <[EMA

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-07 Thread Jeff Garzik
Matteo Croce wrote: Il Friday 07 September 2007 00:30:25 Andrew Morton ha scritto: On Thu, 6 Sep 2007 17:34:10 +0200 Matteo Croce <[EMAIL PROTECTED]> wrote: Driver for the cpmac 100M ethernet driver. It works fine disabling napi support, enabling it gives a kernel panic when the first IPv6 packe

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-07 Thread Geert Uytterhoeven
On Thu, 6 Sep 2007, Andrew Morton wrote: > > On Thu, 6 Sep 2007 17:34:10 +0200 Matteo Croce <[EMAIL PROTECTED]> wrote: > > Driver for the cpmac 100M ethernet driver. > > It works fine disabling napi support, enabling it gives a kernel panic > > when the first IPv6 packet has to be forwarded. > > Ot

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-06 Thread Andrew Morton
> On Fri, 7 Sep 2007 01:21:41 +0200 Matteo Croce <[EMAIL PROTECTED]> wrote: > > The patch introduces vast number of volatile structure fields. Please see > > Documentation/volatile-considered-harmful.txt. > > Removing them and the kernel hangs at module load They can't just be removed. Please s

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-06 Thread Matteo Croce
Il Friday 07 September 2007 00:30:25 Andrew Morton ha scritto: > > On Thu, 6 Sep 2007 17:34:10 +0200 Matteo Croce <[EMAIL PROTECTED]> wrote: > > Driver for the cpmac 100M ethernet driver. > > It works fine disabling napi support, enabling it gives a kernel panic > > when the first IPv6 packet has t

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-06 Thread Randy Dunlap
On Thu, 6 Sep 2007 15:30:25 -0700 Andrew Morton wrote: > > On Thu, 6 Sep 2007 17:34:10 +0200 Matteo Croce <[EMAIL PROTECTED]> wrote: > > Driver for the cpmac 100M ethernet driver. > > It works fine disabling napi support, enabling it gives a kernel panic > > when the first IPv6 packet has to be fo

Re: [PATCH][MIPS][7/7] AR7: ethernet

2007-09-06 Thread Andrew Morton
> On Thu, 6 Sep 2007 17:34:10 +0200 Matteo Croce <[EMAIL PROTECTED]> wrote: > Driver for the cpmac 100M ethernet driver. > It works fine disabling napi support, enabling it gives a kernel panic > when the first IPv6 packet has to be forwarded. > Other than that works fine. > I'm not too sure why