On Wed, Aug 16, 2006 at 09:13:14AM -0400, jamal wrote:
>
> Herbert, I actually dont know the answer that is why i am punting it to
> you;-> I would just move the whole thing to linux/jiffies.h as is but
> you seem to suggest there may be other boundary checks. If yes, go at
> it ;->
I think it's
On Tue, 2006-15-08 at 22:59 -0400, jamal wrote:
> > How about moving
> > it to linux/jiffies.h and rewrite in the style of msec_to_jiffies?
> >
>
> Is there something other than the boundary check already done you
> foresee being made? If yes, do you wanna take a crack at it?
Herbert, I actual
On Wed, 2006-16-08 at 12:33 +1000, Herbert Xu wrote:
> On Tue, Aug 15, 2006 at 09:58:19PM -0400, jamal wrote:
> > +static inline unsigned long make_jiffies(long secs)
> > +{
> > + if (secs >= (MAX_SCHEDULE_TIMEOUT-1)/HZ)
> > + return MAX_SCHEDULE_TIMEOUT-1;
> > + else
> > +
On Tue, Aug 15, 2006 at 09:58:19PM -0400, jamal wrote:
>
> diff --git a/include/net/xfrm.h b/include/net/xfrm.h
> index 8123d49..05444dd 100644
> --- a/include/net/xfrm.h
> +++ b/include/net/xfrm.h
> @@ -619,6 +619,14 @@ xfrm_state_addr_cmp(struct xfrm_tmpl *tm
> return !0;
> }
>
> +static
make_jiffies definition is repeated in xfrm_state and xfrm_policy.
Aggregate in header instead. Against Dave's last perf improvement
patches.
signed-off-by: Jamal Hadi Salim<[EMAIL PROTECTED]>
diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index 8123d49..05444dd 100644
--- a/include/net/
