Re: [PATCH][INET_DIAG]: Fix inet_diag_lock_handler error path

2008-01-28 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 28 Jan 2008 22:03:10 +1100 > On Mon, Jan 28, 2008 at 12:20:50AM -0200, Arnaldo Carvalho de Melo wrote: > > Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=9825 > > > > The inet_diag_lock_handler function uses ERR_PTR to encode errors but > > its c

Re: [PATCH][INET_DIAG]: Fix inet_diag_lock_handler error path

2008-01-28 Thread Herbert Xu
On Mon, Jan 28, 2008 at 12:20:50AM -0200, Arnaldo Carvalho de Melo wrote: > Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=9825 > > The inet_diag_lock_handler function uses ERR_PTR to encode errors but > its callers were testing against NULL. Thanks for catching this Arnaldo! -- Visit Openswa

[PATCH][INET_DIAG]: Fix inet_diag_lock_handler error path

2008-01-27 Thread Arnaldo Carvalho de Melo
Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=9825 The inet_diag_lock_handler function uses ERR_PTR to encode errors but its callers were testing against NULL. This only happens when the only inet_diag modular user, DCCP, is not built into the kernel or available as a module. Also there was