Re: [PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-30 Thread Herbert Xu
On Thu, Nov 29, 2007 at 04:35:43PM +, Steven Whitehouse wrote: > > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > Acked-by: Steven Whitehouse <[EMAIL PROTECTED]> Patch applied. Thanks Pavel! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]

Re: [PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-29 Thread Steven Whitehouse
Hi, On Thu, Nov 29, 2007 at 07:29:20PM +0300, Pavel Emelyanov wrote: > As far as I see from the err variable initialization > the dn_nl_deladdr() routine was designed to report errors > like "EADDRNOTAVAIL" and probaby "ENODEV". > > But the code sets this err to 0 after the first nlmsg_parse > an

[PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-29 Thread Pavel Emelyanov
As far as I see from the err variable initialization the dn_nl_deladdr() routine was designed to report errors like "EADDRNOTAVAIL" and probaby "ENODEV". But the code sets this err to 0 after the first nlmsg_parse and goes on, returning this 0 in any case. Is this made deliberately, or the patch