Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-31 Thread Jeff V. Merkey
Linas Vepstas wrote: On Thu, Mar 30, 2006 at 09:14:56PM -0700, Jeffrey V. Merkey wrote: Yes, we need one. The adapter needs to maintain these stats from the registers in the kernel structure and not its own local variables. Did you read the code to see what the adapter does with thes

Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-31 Thread Rick Jones
2) What's wrong with taking deltas? Typical through-put performance measurement is done by pre-loading the pipes (i.e. running for a few minutes wihtout measuring, then starting the measurement). I'd think that snapshotting the numbers would be easier, and is trivially doable in user-space. I gue

Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-31 Thread Linas Vepstas
On Thu, Mar 30, 2006 at 09:46:54PM -0800, Greg KH wrote: > > (hint, use a tab...) glurg. [PATCH]: e1000: prevent statistics from getting garbled during reset. If a PCI bus error/fault triggers a PCI bus reset, attempts to get the ethernet packet count statistics from the hardware wil

Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-31 Thread Linas Vepstas
On Thu, Mar 30, 2006 at 09:14:56PM -0700, Jeffrey V. Merkey wrote: > Yes, we need one. The adapter needs to maintain these stats from the > registers in the kernel structure and not > its own local variables. Did you read the code to see what the adapter does with these stats? Among other things

Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-30 Thread Greg KH
On Thu, Mar 30, 2006 at 06:02:08PM -0600, Linas Vepstas wrote: > - /* Prevent stats update while adapter is being reset */ > + /* Prevent stats update while adapter is being reset, > + * or if the pci connection is down. */ > if (adapter->link_speed == 0) > return;

Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-30 Thread Jeffrey V. Merkey
Linas Vepstas wrote: On Thu, Mar 30, 2006 at 06:05:45PM -0700, Jeff V. Merkey wrote: Linas Vepstas wrote: Well, these comments have nothing to do with my patch, but ... anyway ... The driver also needs to be fixed to allow clearing of the stats (like all the other adapter drive

Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-30 Thread Linas Vepstas
On Thu, Mar 30, 2006 at 06:05:45PM -0700, Jeff V. Merkey wrote: > > Linas Vepstas wrote: Well, these comments have nothing to do with my patch, but ... anyway ... > The driver also needs to be fixed to allow clearing of the stats (like > all the other adapter drivers). At present, when I run

Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-30 Thread Jeff V. Merkey
Linas Vepstas wrote: On Thu, Mar 30, 2006 at 03:39:28PM -0600, Linas Vepstas wrote: Please review, sign-off/ack, and forward upstream. --linas Per feedback, here's a slightly more human-readable version. --linas [PATCH]: e1000: prevent statistics from getting garbled during

Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-30 Thread Linas Vepstas
On Thu, Mar 30, 2006 at 03:39:28PM -0600, Linas Vepstas wrote: > > Please review, sign-off/ack, and forward upstream. > --linas Per feedback, here's a slightly more human-readable version. --linas [PATCH]: e1000: prevent statistics from getting garbled during reset. If a PCI b

[PATCH]: e1000: prevent statistics from getting garbled during reset.

2006-03-30 Thread Linas Vepstas
Please review, sign-off/ack, and forward upstream. --linas [PATCH]: e1000: prevent statistics from getting garbled during reset. If a PCI bus error/fault triggers a PCI bus reset, attempts to get the ethernet packet count statistics from the hardware will fail, returning garbage data upstream