Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-09-25 Thread Auke Kok
Linas Vepstas wrote: Resending a minor janitorial patch from long ago that seems to have fallen through the cracks. Its not in 2.6.18-git4 nor in 2.6.18-mm1. Please apply and forward upstream. --linas [PATCH]: e1000: Janitor: Use #defined values for literals Minor janitorial patch: use

[PATCH]: e1000: Janitor: Use #defined values for literals

2006-09-25 Thread Linas Vepstas
Resending a minor janitorial patch from long ago that seems to have fallen through the cracks. Its not in 2.6.18-git4 nor in 2.6.18-mm1. Please apply and forward upstream. --linas [PATCH]: e1000: Janitor: Use #defined values for literals Minor janitorial patch: use #defines for literal

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-08-07 Thread Jeff Garzik
hopefully queued-by, as well... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-08-07 Thread Auke Kok
Linas Vepstas wrote: Resending patch from 23 June 2006; there was some confusion about whether a similar patch had already been applied; seems it wasn't. Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Acked-by: Auke Kok <[EMAIL PROTEC

[PATCH]: e1000: Janitor: Use #defined values for literals

2006-08-07 Thread Linas Vepstas
Resending patch from 23 June 2006; there was some confusion about whether a similar patch had already been applied; seems it wasn't. Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/e1000/e1000_main.c |4 ++-- 1 file

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-27 Thread Auke Kok
Linas Vepstas wrote: On Fri, Jun 23, 2006 at 01:07:21PM -0700, Auke Kok wrote: Linas Vepstas wrote: Minor janitorial patch: use #defines for literal values. + pci_enable_wake(pdev, PCI_D3hot, 0); + pci_enable_wake(pdev, PCI_D3cold, 0); I Acked this but that's silly - the patches sen

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-27 Thread Linas Vepstas
On Fri, Jun 23, 2006 at 01:07:21PM -0700, Auke Kok wrote: > Linas Vepstas wrote: > >Minor janitorial patch: use #defines for literal values. > >+pci_enable_wake(pdev, PCI_D3hot, 0); > >+pci_enable_wake(pdev, PCI_D3cold, 0); > > I Acked this but that's silly - the patches sent yesterday alr

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-23 Thread Linas Vepstas
On Fri, Jun 23, 2006 at 01:07:21PM -0700, Auke Kok wrote: > Linas Vepstas wrote: > >Minor janitorial patch: use #defines for literal values. > > > >-pci_enable_wake(pdev, 3, 0); > >-pci_enable_wake(pdev, 4, 0); /* 4 == D3 cold */ > >+pci_enable_wake(pdev, PCI_D3hot, 0); > >+pci_enab

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-23 Thread Auke Kok
Linas Vepstas wrote: Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/e1000/e1000_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.17-rc6-mm2/drivers/net/e1000/e1000_main.c =

Re: [PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-23 Thread Auke Kok
Linas Vepstas wrote: Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Ack! I thought we had gotten these out already. Cheers, Auke drivers/net/e1000/e1000_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH]: e1000: Janitor: Use #defined values for literals

2006-06-23 Thread Linas Vepstas
Minor janitorial patch: use #defines for literal values. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/e1000/e1000_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.17-rc6-mm2/drivers/net/e1000/e1000_main.c ===