Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-31 Thread Jens Axboe
On Wed, Oct 31 2007, Herbert Xu wrote: > On Tue, Oct 30, 2007 at 08:40:02PM -0700, David Miller wrote: > > > > I just checked the following bug fix into net-2.6 > > Thanks for getting to the bottom of this Dave! I seem to have > mistaken the = for a |= in sg_mark_end :) I don't blame you, that f

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-31 Thread Herbert Xu
On Tue, Oct 30, 2007 at 08:40:02PM -0700, David Miller wrote: > > I just checked the following bug fix into net-2.6 Thanks for getting to the bottom of this Dave! I seem to have mistaken the = for a |= in sg_mark_end :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{P

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-31 Thread Jens Axboe
On Wed, Oct 31 2007, David Miller wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 09:14:28 +0100 > > > Subject: [PATCH] [SG] Get rid of __sg_mark_end() > > > > sg_mark_end() overwrites the page_link information, but all users want > > __sg_mark_end() behaviour where we just

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-31 Thread David Miller
From: Jens Axboe <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 09:14:28 +0100 > Subject: [PATCH] [SG] Get rid of __sg_mark_end() > > sg_mark_end() overwrites the page_link information, but all users want > __sg_mark_end() behaviour where we just set the end bit. That is the most > natural way to use

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-31 Thread Jens Axboe
On Wed, Oct 31 2007, David Miller wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 08:46:21 +0100 > > > On Tue, Oct 30 2007, David Miller wrote: > > > @@ -293,7 +293,7 @@ decryptor(struct scatterlist *sg, void *data) > > > if (thislen == 0) > > > return 0; > > >

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-31 Thread Jens Axboe
On Wed, Oct 31 2007, David Miller wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 09:01:43 +0100 > > > On Wed, Oct 31 2007, David Miller wrote: > > > From: Jens Axboe <[EMAIL PROTECTED]> > > > Date: Wed, 31 Oct 2007 08:46:21 +0100 > > > > > > > On Tue, Oct 30 2007, David Mi

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-31 Thread David Miller
From: Jens Axboe <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 09:01:43 +0100 > On Wed, Oct 31 2007, David Miller wrote: > > From: Jens Axboe <[EMAIL PROTECTED]> > > Date: Wed, 31 Oct 2007 08:46:21 +0100 > > > > > On Tue, Oct 30 2007, David Miller wrote: > > > > @@ -293,7 +293,7 @@ decryptor(struct

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-31 Thread Jens Axboe
On Wed, Oct 31 2007, David Miller wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 08:46:21 +0100 > > > On Tue, Oct 30 2007, David Miller wrote: > > > @@ -293,7 +293,7 @@ decryptor(struct scatterlist *sg, void *data) > > > if (thislen == 0) > > > return 0; > > >

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread David Miller
From: Jens Axboe <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 08:46:21 +0100 > On Tue, Oct 30 2007, David Miller wrote: > > @@ -293,7 +293,7 @@ decryptor(struct scatterlist *sg, void *data) > > if (thislen == 0) > > return 0; > > > > - sg_mark_end(desc->frags, desc->fragno); > >

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread Jens Axboe
On Wed, Oct 31 2007, David Miller wrote: > From: Jens Axboe <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 08:32:07 +0100 > > > [SG] Remove __sg_mark_end() > > > > Make sg_mark_end() NOT overwrite the page link. Then it can be used > > after filling the sg table, which is what users want. That mean

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread Jens Axboe
On Tue, Oct 30 2007, David Miller wrote: > diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c > b/net/sunrpc/auth_gss/gss_krb5_crypto.c > index 91cd8f0..4a8aa94 100644 > --- a/net/sunrpc/auth_gss/gss_krb5_crypto.c > +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c > @@ -211,8 +211,8 @@ encryptor(struct

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread David Miller
From: Jens Axboe <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 08:32:07 +0100 > [SG] Remove __sg_mark_end() > > Make sg_mark_end() NOT overwrite the page link. Then it can be used > after filling the sg table, which is what users want. That means that > __sg_mark_end() is no longer useful, so kill i

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread Jens Axboe
On Tue, Oct 30 2007, David Miller wrote: > > I just checked the following bug fix into net-2.6 > > Rusty, have a quick look at virtio_net wrt. the changes I > made to skb_to_sgvec()'s behavior. I think I might have > even fixed something :-) > > Jens, please review my commentary wrt. sg_mark_en

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 17:06:32 +1100 > On Wednesday 31 October 2007 14:40:02 David Miller wrote: > > I just checked the following bug fix into net-2.6 > > > > Rusty, have a quick look at virtio_net wrt. the changes I > > made to skb_to_sgvec()'s behavior.

Re: [PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread Rusty Russell
On Wednesday 31 October 2007 14:40:02 David Miller wrote: > I just checked the following bug fix into net-2.6 > > Rusty, have a quick look at virtio_net wrt. the changes I > made to skb_to_sgvec()'s behavior. I think I might have > even fixed something :-) Grr, the scatterlist changes are really

[PATCH]: Fix networking scatterlist regressions.

2007-10-30 Thread David Miller
I just checked the following bug fix into net-2.6 Rusty, have a quick look at virtio_net wrt. the changes I made to skb_to_sgvec()'s behavior. I think I might have even fixed something :-) Jens, please review my commentary wrt. sg_mark_end() and it's nonintuitive behavior which led to these bug