Re: [PATCH/RFT net] ravb: expand rx descriptor data to accommodate hw checksum

2018-12-16 Thread Simon Horman
On Mon, Dec 10, 2018 at 07:56:14PM +0300, Sergei Shtylyov wrote: > Hello! > > On 12/10/2018 11:59 AM, Simon Horman wrote: > > > From: Simon Horman > > > > EtherAVB may provide a checksum of packet data appended to packet data. In > > order to allow this checksum to be received by the host descr

Re: [PATCH/RFT net] ravb: expand rx descriptor data to accommodate hw checksum

2018-12-10 Thread Sergei Shtylyov
On 12/10/2018 10:51 PM, Sergei Shtylyov wrote: >>> +#define RAVB_CSUM_LEN 2 >>> + >> ... >>> priv->rx_buf_sz = (ndev->mtu <= 1492 ? PKT_BUF_SZ : ndev->mtu) + >>> - ETH_HLEN + VLAN_HLEN; >>> + ETH_HLEN + VLAN_HLEN + RAVB_CSUM_LEN; >> ... >>> + if (unlikely(skb->len < RAV

Re: [PATCH/RFT net] ravb: expand rx descriptor data to accommodate hw checksum

2018-12-10 Thread Sergei Shtylyov
On 12/10/2018 10:44 PM, David Miller wrote: >> +#define RAVB_CSUM_LEN 2 >> + > ... >> priv->rx_buf_sz = (ndev->mtu <= 1492 ? PKT_BUF_SZ : ndev->mtu) + >> -ETH_HLEN + VLAN_HLEN; >> +ETH_HLEN + VLAN_HLEN + RAVB_CSUM_LEN; > ... >> +if (unlikely(skb->len < RAVB_CSUM_

Re: [PATCH/RFT net] ravb: expand rx descriptor data to accommodate hw checksum

2018-12-10 Thread David Miller
From: Simon Horman Date: Mon, 10 Dec 2018 09:59:17 +0100 > +#define RAVB_CSUM_LEN 2 > + ... > priv->rx_buf_sz = (ndev->mtu <= 1492 ? PKT_BUF_SZ : ndev->mtu) + > - ETH_HLEN + VLAN_HLEN; > + ETH_HLEN + VLAN_HLEN + RAVB_CSUM_LEN; ... > + if (unlikely(skb->len < RA

Re: [PATCH/RFT net] ravb: expand rx descriptor data to accommodate hw checksum

2018-12-10 Thread Sergei Shtylyov
Hello! On 12/10/2018 11:59 AM, Simon Horman wrote: > From: Simon Horman > > EtherAVB may provide a checksum of packet data appended to packet data. In > order to allow this checksum to be received by the host descriptor data > needs to be enlarged by 2 bytes to accommodate the checksum. > > In

[PATCH/RFT net] ravb: expand rx descriptor data to accommodate hw checksum

2018-12-10 Thread Simon Horman
From: Simon Horman EtherAVB may provide a checksum of packet data appended to packet data. In order to allow this checksum to be received by the host descriptor data needs to be enlarged by 2 bytes to accommodate the checksum. In the case of MTU-sized packets without a VLAN tag the checksum were