Re: [PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-27 Thread Simon Horman
Hi Scott, On Wed, May 27, 2015 at 12:34:57AM -0700, Scott Feldman wrote: > On Tue, May 26, 2015 at 6:07 PM, Simon Horman > wrote: [snip] > > I have some questions about that approach: > > > > * Does that behaviour differ from other devices > > (that don't set NETIF_F_HW_VLAN_CTAG_FILTER)? > >

Re: [PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-27 Thread Scott Feldman
On Tue, May 26, 2015 at 6:07 PM, Simon Horman wrote: > Hi Scott, > > On Tue, May 26, 2015 at 02:04:00AM -0700, Scott Feldman wrote: >> On Tue, May 26, 2015 at 12:28 AM, Scott Feldman wrote: >> > On Mon, May 25, 2015 at 5:55 PM, Simon Horman >> > wrote: >> >> This will occur anyway if the 8021q m

Re: [PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-26 Thread Simon Horman
Hi Scott, On Tue, May 26, 2015 at 02:04:00AM -0700, Scott Feldman wrote: > On Tue, May 26, 2015 at 12:28 AM, Scott Feldman wrote: > > On Mon, May 25, 2015 at 5:55 PM, Simon Horman > > wrote: > >> This will occur anyway if the 8021q module is loaded as it will > >> call rocker_port_vlan_rx_add_vi

Re: [PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-26 Thread Scott Feldman
On Tue, May 26, 2015 at 12:28 AM, Scott Feldman wrote: > On Mon, May 25, 2015 at 5:55 PM, Simon Horman > wrote: >> This will occur anyway if the 8021q module is loaded as it will >> call rocker_port_vlan_rx_add_vid for vlan 0. This code is here >> to handle the case where the 8021q module is not

Re: [PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-26 Thread Scott Feldman
On Mon, May 25, 2015 at 5:55 PM, Simon Horman wrote: > This will occur anyway if the 8021q module is loaded as it will > call rocker_port_vlan_rx_add_vid for vlan 0. This code is here > to handle the case where the 8021q module is not loaded. > > This patch also handles the case where the 8021q is

[PATCH/RFC net-next] rocker: by default accept untagged packets

2015-05-25 Thread Simon Horman
This will occur anyway if the 8021q module is loaded as it will call rocker_port_vlan_rx_add_vid for vlan 0. This code is here to handle the case where the 8021q module is not loaded. This patch also handles the case where the 8021q is unloaded removing all VLANs from all ports. This change shoul