Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-26 Thread Eric W. Biederman
David Miller <[EMAIL PROTECTED]> writes: > Thanks for doing this. > > But this appears to be still discussed, so I'll give > Denis and others another day to work out the fix they > want to include. At this point I think all that really needs to happen is to remove __net_initdata. The function at

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-26 Thread David Miller
From: Benjamin Thery <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 13:41:55 +0200 > David Miller wrote: > > From: [EMAIL PROTECTED] (Eric W. Biederman) > > Date: Thu, 25 Oct 2007 11:21:55 -0600 > > > >>> By the way, I think that we can in the case of undefined CONFIG_NET_NS > >>> reduce register to

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-26 Thread Benjamin Thery
David Miller wrote: > From: [EMAIL PROTECTED] (Eric W. Biederman) > Date: Thu, 25 Oct 2007 11:21:55 -0600 > >>> By the way, I think that we can in the case of undefined CONFIG_NET_NS >>> reduce register to calling ->init method and unregister to calling >>> ->exit method. >>> >>> This is a correct

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-26 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 25 Oct 2007 11:21:55 -0600 > > By the way, I think that we can in the case of undefined CONFIG_NET_NS > > reduce register to calling ->init method and unregister to calling > > ->exit method. > > > > This is a correct thing at least for now an

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Eric W. Biederman
"Denis V. Lunev" <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Benjamin Thery <[EMAIL PROTECTED]> writes: >> >>> Eric W. Biederman wrote: Benjamin Thery <[EMAIL PROTECTED]> writes: > Denis V. Lunev wrote: >> The patch attached should help. The idea is simple. The "in

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Denis V. Lunev
Eric W. Biederman wrote: > Benjamin Thery <[EMAIL PROTECTED]> writes: > >> Eric W. Biederman wrote: >>> Benjamin Thery <[EMAIL PROTECTED]> writes: >>> Denis V. Lunev wrote: > The patch attached should help. The idea is simple. The "init" should be > called only once without NETNS. Per

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Eric W. Biederman
Benjamin Thery <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Benjamin Thery <[EMAIL PROTECTED]> writes: >> >>> Denis V. Lunev wrote: The patch attached should help. The idea is simple. The "init" should be called only once without NETNS. Period. No need for any lists. >>> Th

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Benjamin Thery
Eric W. Biederman wrote: > Benjamin Thery <[EMAIL PROTECTED]> writes: > >> Denis V. Lunev wrote: >>> The patch attached should help. The idea is simple. The "init" should be >>> called only once without NETNS. Period. No need for any lists. >> This is the kind of idea I had but I didn't think it c

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Eric W. Biederman
Benjamin Thery <[EMAIL PROTECTED]> writes: > Denis V. Lunev wrote: >> The patch attached should help. The idea is simple. The "init" should be >> called only once without NETNS. Period. No need for any lists. > > This is the kind of idea I had but I didn't think it could be > that simple. :) > T

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Eric W. Biederman
"Denis V. Lunev" <[EMAIL PROTECTED]> writes: > The patch attached should help. The idea is simple. The "init" should be > called only once without NETNS. Period. No need for any lists. > > I'll resend it to Dave after the ACK. First in the case of the code that is currently merged none of the __

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Benjamin Thery
Denis V. Lunev wrote: > The patch attached should help. The idea is simple. The "init" should be > called only once without NETNS. Period. No need for any lists. This is the kind of idea I had but I didn't think it could be that simple. :) Thanks Denis. > I'll resend it to Dave after the ACK.

Re: [Devel] Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n (resend, was wrong patch)

2007-10-25 Thread Denis V. Lunev
Denis V. Lunev wrote: > The patch attached should help. The idea is simple. The "init" should be > called only once without NETNS. Period. No need for any lists. > > I'll resend it to Dave after the ACK. > > Regards, > Den > > Benjamin Thery wrote: >> Hello Pavel, >> >> I've found a proble

Re: [NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Denis V. Lunev
The patch attached should help. The idea is simple. The "init" should be called only once without NETNS. Period. No need for any lists. I'll resend it to Dave after the ACK. Regards, Den Benjamin Thery wrote: > Hello Pavel, > > I've found a problem with one of your patch related to netn

[NETNS] Oops in register_pernet_operations() with CONFIG_NET_NS=n

2007-10-25 Thread Benjamin Thery
Hello Pavel, I've found a problem with one of your patch related to netns: * [NETNS] Move some code into __init section when CONFIG_NET_NS=n (v2) http://www.spinics.net/lists/netdev/msg43310.html This patch introduces the __net_init/__net_exit/__net_initdata defines to save some memory when C